Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature mbl #1212

Merged
merged 4 commits into from
Feb 1, 2020
Merged

Feature mbl #1212

merged 4 commits into from
Feb 1, 2020

Conversation

JamzTheMan
Copy link
Member

@JamzTheMan JamzTheMan commented Feb 1, 2020

Test branch to play with new Movement Blocking Layer and offer opinions.

Feel free to comment on code but would like to get this merged to feature branch and I'll make code adjustments if needed before we merge to develop branch.

TODO
Moved to issue #1216


This change is Reviewable

JamzTheMan and others added 4 commits January 27, 2020 18:26
 * Same tools used as VBL with extra button that defines which layer(s) the polygons are drawn on.

Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
 * Same tools used as VBL with extra button that defines which layer(s) the polygons are drawn on.
 * Changes included (and to be tested) include client/server commands to properly send VBL/MBL to other clients
 * AppPreferences persist last ToolbarPanel presses
 * TODO: Make AI buttons for GM persist over to Player clients and disable buttons on Player clients when server is running

Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
@JamzTheMan JamzTheMan added feature Adding functionality that adds value M Medium impact. T-shirt style story pointing/scope labels Feb 1, 2020
@JamzTheMan JamzTheMan self-assigned this Feb 1, 2020
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 17 files at r1, 1 of 1 files at r2, 21 of 21 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cwisniew)

@Phergus Phergus merged commit ab1eda4 into RPTools:feature-mbl Feb 1, 2020
@Phergus
Copy link
Contributor

Phergus commented Feb 1, 2020

@JamzTheMan Did you accidentally paste the call to setTopologyMode() twice in MapTool.java postInitialize()?

@Phergus
Copy link
Contributor

Phergus commented Feb 1, 2020

Start of MBL feature #1216

@JamzTheMan
Copy link
Member Author

Probably accidently, was going to need to do the same for another button and forgot to remove.

@JamzTheMan JamzTheMan deleted the feature-mbl branch February 21, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value M Medium impact. T-shirt style story pointing/scope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants